bereng commented on code in PR #2508:
URL: https://github.com/apache/cassandra/pull/2508#discussion_r1273389098
##########
src/java/org/apache/cassandra/db/DeletionTime.java:
##########
@@ -121,7 +120,7 @@ public void digest(Digest digest)
*/
public boolean validate()
{
- return true;
+ return markedForDeleteAt >= 0 || isLive();
Review Comment:
I would amend the comment of the method. Mentioning a negative ldt and that
not being checked is confusing imo.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
