michaelsembwever commented on code in PR #2238:
URL: https://github.com/apache/cassandra/pull/2238#discussion_r1276539613
##########
.build/parent-pom-template.xml:
##########
@@ -628,17 +629,17 @@
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-core</artifactId>
- <version>3.1.5</version>
+ <version>${metrics.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-jvm</artifactId>
- <version>3.1.5</version>
+ <version>${metrics.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-logback</artifactId>
- <version>3.1.5</version>
+ <version>${metrics.version}</version>
Review Comment:
I'm not sure they know what they are talking about.
What does
```
grep -r "metrics.version" ~/.m2/repository/io/dropwizard/metrics
```
give you?
Educate me please if I'm missing something, I see nothing in their parent
pom, and we're not pulling in a bom.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
