Mmuzaf commented on code in PR #2238:
URL: https://github.com/apache/cassandra/pull/2238#discussion_r1276630063
##########
.build/parent-pom-template.xml:
##########
@@ -628,17 +629,17 @@
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-core</artifactId>
- <version>3.1.5</version>
+ <version>${metrics.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-jvm</artifactId>
- <version>3.1.5</version>
+ <version>${metrics.version}</version>
</dependency>
<dependency>
<groupId>io.dropwizard.metrics</groupId>
<artifactId>metrics-logback</artifactId>
- <version>3.1.5</version>
+ <version>${metrics.version}</version>
Review Comment:
I don't know the reasoning covered behind the message, but I understand it
as follows: if a user is using the cassandra parent and wants to use additional
modules provided by the dropwizard metrics project he/she should refer to the
{metrics.version} inherited from the cassandra-parent when adding these
dependencies. So if the cassandra project updates the {metrics.version} version
of the dropwizard metrics library and a user wants to update the
cassandra-parent accordingly, all dropwizard metrics extensions will be the
same version and there will be no conflict between them.
But maybe I'm missing something, so I don't have anything against using the
`4.2.19` directly.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
