michaelsembwever commented on code in PR #229:
URL: https://github.com/apache/cassandra-dtest/pull/229#discussion_r1277325997
##########
upgrade_tests/upgrade_manifest.py:
##########
@@ -248,14 +248,16 @@ def build_upgrade_pairs():
logger.debug("{} appears applicable to current env.
Overriding final test version from {} to {}".format(path_name, oldmeta.version,
newmeta.version))
destination_meta = newmeta
- valid_upgrade_pairs.append(
- UpgradePath(
- name=path_name,
- starting_version=origin_meta.version,
- upgrade_version=destination_meta.version,
- starting_meta=origin_meta,
- upgrade_meta=destination_meta
+ from upgrade_tests.upgrade_through_versions_test import
jdk_compatible_steps
Review Comment:
nit: maybe `jdk_compatible_steps` should be moved here ( to
upgrade_manifest.py ). this is more the base file.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
