Mmuzaf commented on code in PR #2519:
URL: https://github.com/apache/cassandra/pull/2519#discussion_r1277442847


##########
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:
##########
@@ -558,7 +558,7 @@ public ColumnFamilyStore(Keyspace keyspace,
         repairManager = new CassandraTableRepairManager(this);
         sstableImporter = new SSTableImporter(this);
 
-        if (SchemaConstants.isSystemKeyspace(getKeyspaceName()))
+        if (DatabaseDescriptor.isClientOrToolInitialized() || 
SchemaConstants.isSystemKeyspace(getKeyspaceName()))

Review Comment:
   I can argue with that, it might also highlight the other places where we 
have to do the same fix :-)



##########
src/java/org/apache/cassandra/db/ColumnFamilyStore.java:
##########
@@ -558,7 +558,7 @@ public ColumnFamilyStore(Keyspace keyspace,
         repairManager = new CassandraTableRepairManager(this);
         sstableImporter = new SSTableImporter(this);
 
-        if (SchemaConstants.isSystemKeyspace(getKeyspaceName()))
+        if (DatabaseDescriptor.isClientOrToolInitialized() || 
SchemaConstants.isSystemKeyspace(getKeyspaceName()))

Review Comment:
   I can argue with that, but it might also highlight the other places where we 
have to do the same fix :-)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to