ekaterinadimitrova2 commented on code in PR #2493:
URL: https://github.com/apache/cassandra/pull/2493#discussion_r1278043222
##########
src/java/org/apache/cassandra/security/ThreadAwareSecurityManager.java:
##########
@@ -46,6 +46,7 @@
* This is better than the penalty of 1 to 3 percent using a standard {@code
SecurityManager} with an <i>allow all</i> policy.
* </p>
*/
+@SuppressWarnings("removal")
Review Comment:
This change clears warnings and hides a future JDK removal we need to
address which will probably require some significant work around UDFs, for
example.
We need to have at least an open ticket for visibility and awareness if we
are going to do this suppression (which I do not fully agree with, honestly).
##########
test/distributed/org/apache/cassandra/distributed/test/InternodeEncryptionOptionsTest.java:
##########
@@ -236,13 +236,14 @@ public void
negotiatedProtocolMustBeAcceptedProtocolTest() throws Throwable
c.set("server_encryption_options",
ImmutableMap.builder().putAll(validKeystore)
.put("internode_encryption", "all")
- .put("accepted_protocols",
ImmutableList.of("TLSv1.1", "TLSv1.2"))
+ .put("accepted_protocols",
ImmutableList.of("TLSv1.1", "TLSv1.2", "TLSv1.3"))
Review Comment:
Good call, thanks!
##########
test/unit/org/apache/cassandra/cql3/RandomSchemaTest.java:
##########
@@ -128,18 +128,18 @@ public void test()
{
ByteBuffer[] partitionKeys = Arrays.copyOf(expected,
partitionColumnCount);
ByteBuffer[] rowKey = Arrays.copyOf(expected,
primaryColumnCount);
- execute(insertStmt, expected);
+ execute(insertStmt, (Object[]) expected);
Review Comment:
In general I prefer not to address unrelated issues (in this case warnings)
at random tickets. In this case I propose we keep them but in a separate
commit, mentioned also on the ticket.
##########
conf/jvm17-server.options:
##########
@@ -130,4 +130,8 @@
# inferior performance and risks exceeding MaxDirectMemory
-Dio.netty.tryReflectionSetAccessible=true
+# Revert changes in defaults introduced in
https://netty.io/news/2022/03/10/4-1-75-Final.html
+-Dio.netty.allocator.useCacheForAllThreads=true
+-Dio.netty.allocator.maxOrder=11
+
Review Comment:
Good call, maybe we also open a follow up ticket to explore if we can
benefit of changing anything on Cassandra side. too? My understanding is that
will require at a minimum some performance testing.
##########
.build/parent-pom-template.xml:
##########
@@ -676,19 +682,35 @@
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-bom</artifactId>
- <version>4.1.58.Final</version>
+ <version>4.1.94.Final</version>
<type>pom</type>
<scope>provided</scope>
</dependency>
<dependency>
<groupId>io.netty</groupId>
<artifactId>netty-all</artifactId>
- <version>4.1.58.Final</version>
+ <version>4.1.94.Final</version>
Review Comment:
There is already 4.1.96
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
