Maxwell-Guo commented on code in PR #2555:
URL: https://github.com/apache/cassandra/pull/2555#discussion_r1286726632
##########
src/java/org/apache/cassandra/db/guardrails/Guardrails.java:
##########
@@ -385,6 +385,18 @@ public final class Guardrails implements GuardrailsMBean
: format("User types cannot have more than %s
columns, but %s provided for user type %s.",
threshold, value, what));
+ /**
+ * Guardrail on the number of dimensions of vector columns.
+ */
+ public static final MaxThreshold vectorDimensions =
+ new MaxThreshold("vector_dimensions",
+ null,
+ state ->
CONFIG_PROVIDER.getOrCreate(state).getVectorDimensionsWarnThreshold(),
+ state ->
CONFIG_PROVIDER.getOrCreate(state).getVectorDimensionsFailThreshold(),
+ (isWarning, what, value, threshold) ->
+ format("%s has a vector of %s dimensions, this exceeds
the %s threshold of %s.",
Review Comment:
what about change the messge to : %s has a vector of %s dimensions, which
exceeds the %s threshold of %s.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
