maedhroz commented on code in PR #2540: URL: https://github.com/apache/cassandra/pull/2540#discussion_r1289124601
########## src/java/org/apache/cassandra/index/sai/disk/v1/sortedterms/SortedTermsWriter.java: ########## @@ -49,9 +43,9 @@ * <p> Review Comment: Thinking through one last time how we explain what's going on here... Rather than saying terms must be added in lexicographical order, would it make more sense to say that they must be added in their unsigned byte-comparable order, given that's what the reader seems to assume? Aside/tangent: Just in general, the use of "term" to describe the values here is almost more confusing than just calling them "blobs" or something. Maybe this was a holdover from a structure in Lucene this was based on originally or something, but what it has become is an ordered sequence of unsigned byte-comparable blobs :D -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
