ekaterinadimitrova2 commented on code in PR #233:
URL: https://github.com/apache/cassandra-website/pull/233#discussion_r1290226039


##########
site-content/source/modules/ROOT/pages/development/how_to_commit.adoc:
##########
@@ -14,35 +14,43 @@ Hypothetical CASSANDRA-12345 ticket is a cassandra-4.0 
based bug fix
 that requires different code for cassandra-4.0, cassandra-4.1, and
 trunk. Contributor Jackie supplied a patch for the root branch
 (12345-4.0.patch), and patches for the remaining branches
-(12345-4.1.patch, 12345-trunk.patch).
+(12345-4.1.patch, 12345-5.0.patch, 12345-trunk.patch).
 
 On cassandra-4.0:::
   . `+git am -3 12345-4.0.patch+` (any problem b/c of CHANGES.txt not
   merging anymore, fix it in place)
-  . `+ant realclean && ant jar build-test+` (rebuild to make sure code
+  . `+ant realclean && ant jar build-test check+` (rebuild to make sure code

Review Comment:
   Actually I just realized I made a mistake, `check` should be added only for 
the 5.0 and trunk branches.
   I will remove `build-test`, thanks



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to