jmckenzie-dev commented on PR #2554: URL: https://github.com/apache/cassandra/pull/2554#issuecomment-1673715782
Ok, highlights of these commits: - Added a header that should make it clear we're not populating the `$TEST_SPLIT_FILE` and why, and how to do so - Added some documentation on the flow of things to that header to clarify what's needed - Added repo / branch / sha references at top of config for reproducibility and to provide the functionality around images you were concerned about (I think?) @dcapwell - Cleaned up jvm and dtest to use the same interim test file name - tidied up some floating / varying cases (all upper should now be env var and requirements for what as env and what cmd should produce what env should be clear now) - Pulled out the timeouts to your point David, but left in a default they all inherit from just in case a user adds a new job w/out specifying and there's no `build.xml` entry for it - Cost calculation now a part of it via `default_split_num` that uses the `$SPLIT_SIZE` that we define on a per-job basis that users can also override. i.e. the higher the split size, the more tests we'll jam in there. - Split out `default_env_vars` from `required_env_vars` and documented to try and make it clear what a downstream implementation should change and what they should leave alone. Phew. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
