adelapena commented on code in PR #2556:
URL: https://github.com/apache/cassandra/pull/2556#discussion_r1291190914
##########
src/java/org/apache/cassandra/cql3/restrictions/TermSlice.java:
##########
@@ -28,6 +28,12 @@
final class TermSlice
{
+ /**
Review Comment:
`TermSlice#isSupportedBy(ColumnMetadata, Index)` seems to reject `NEQ`
expressions. Thus, if we have:
```
CREATE TABLE t (k int PRIMARY KEY, v int);
CREATE INDEX ON t(v) USING 'sai';
```
The query `SELECT * FROM t WHERE v!=0;` will require `ALLOW FILTERING`,
whereas for example the query `SELECT * FROM t WHERE v>0;` will be accepted
without AF. I think both queries should be accepted without AF, shouldn't they?
We should probably include the new operators in `AllowFilteringTest`.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
