dcapwell commented on code in PR #43:
URL: https://github.com/apache/cassandra-accord/pull/43#discussion_r1294017398
##########
accord-core/src/test/java/accord/burn/BurnTest.java:
##########
@@ -228,35 +234,53 @@ static void burn(RandomSource random, TopologyFactory
topologyFactory, List<Id>
// not used for atomicity, just for encapsulation
AtomicReference<Runnable> onSubmitted = new AtomicReference<>();
- Consumer<Packet> responseSink = packet -> {
- ListResult reply = (ListResult) packet.message;
- if (replies[(int)packet.replyId] != null)
- return;
-
+ Runnable maybeTriggerNextRequest = () -> {
if (requestIndex.get() < requests.length)
{
int i = requestIndex.getAndIncrement();
starts[i] = clock.incrementAndGet();
- queue.add(requests[i]);
+ // TODO (review): why did i add this again?
Review Comment:
Not looked at this since April so I don't remember why I added this... there
was a reason, but don't remember...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
