belliottsmith commented on code in PR #56:
URL: https://github.com/apache/cassandra-accord/pull/56#discussion_r1296136638
##########
accord-core/src/test/java/accord/impl/list/ListAgent.java:
##########
@@ -46,11 +52,16 @@ public ListAgent(long timeout, Consumer<Throwable>
onFailure, Consumer<Runnable>
@Override
public void onRecover(Node node, Result success, Throwable fail)
{
+ if (fail != null)
+ {
+ checkState(success == null, "fail (%s) and success (%s) are both
not null", fail, success);
+ // We don't really process errors for Recover here even though it
is provided in the interface
Review Comment:
This is only for the ListAgent, which is used only for testing purposes. We
keep enough information to issue a response directly to clients for testing so
we get more responses to analyse the correctness of.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
