arjunashok commented on code in PR #58:
URL: https://github.com/apache/cassandra-sidecar/pull/58#discussion_r1300511317
##########
src/test/integration/org/apache/cassandra/testing/CassandraTestTemplate.java:
##########
@@ -148,34 +149,21 @@ private BeforeEachCallback beforeEach()
int nodesPerDc = annotation.nodesPerDc();
int dcCount = annotation.numDcs();
int newNodesPerDc = annotation.newNodesPerDc(); // if the test
wants to add more nodes later
+ Preconditions.checkArgument(newNodesPerDc >= 0,
+ "newNodesPerDc cannot be a
negative number");
+ int originalNodeCount = nodesPerDc * dcCount;
int finalNodeCount = dcCount * (nodesPerDc + newNodesPerDc);
Versions.Version requestedVersion = versions.getLatest(new
Semver(version.version(),
Semver.SemverType.LOOSE));
SimpleCassandraVersion versionParsed =
SimpleCassandraVersion.create(version.version());
UpgradeableCluster.Builder clusterBuilder =
- UpgradeableCluster.build(nodesPerDc * dcCount)
- .withVersion(requestedVersion)
- .withDCs(dcCount)
-
.withDataDirCount(annotation.numDataDirsPerInstance())
- .withConfig(config -> {
- if (annotation.nativeTransport())
- {
- config.with(Feature.NATIVE_PROTOCOL);
- }
- if (annotation.jmx())
- {
- config.with(Feature.JMX);
- }
- if (annotation.gossip())
- {
- config.with(Feature.GOSSIP);
- }
- if (annotation.network())
- {
- config.with(Feature.NETWORK);
- }
- });
+ UpgradeableCluster.build(originalNodeCount)
+// .withDynamicPortAllocation(true) // to
allow parallel test runs
Review Comment:
Temporarily disabled parallel runs as it was not playing well with in-jvm
dtest based integration tests
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
