smiklosovic commented on code in PR #2620: URL: https://github.com/apache/cassandra/pull/2620#discussion_r1301343775
########## .build/build-sonar.xml: ########## @@ -0,0 +1,158 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> +<project basedir="." name="apache-cassandra-sonar-tasks" xmlns:if="ant:if" xmlns:unless="ant:unless"> + <property name="sonar-scanner-cli.version" value="5.0.1.3006-linux"/> + <property name="sonar.workdir" value="${build.dir}/sonar"/> + <property name="sonar.download.dir" value="${user.home}/.cassandra-cache/tools"/> + <property name="sonar-scanner.home" value="${sonar.download.dir}/sonar-scanner-${sonar-scanner-cli.version}"/> + <property name="sonar.projectKey" value="cassandra"/> + <property name="sonar.mainBranch" value="trunk"/> Review Comment: This would be nice to have automatically resolved based on what branch this file is in. I get that we will probably use this from now on only but once trunk is cassandra-5.1 and we are doing some patches for it, would not it be nice if we have a way how to run Sonar against that branch too without tweaking this property every time? ########## .build/build-sonar.xml: ########## @@ -0,0 +1,158 @@ +<?xml version="1.0" encoding="UTF-8" standalone="no"?> +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, software + ~ distributed under the License is distributed on an "AS IS" BASIS, + ~ WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. + ~ See the License for the specific language governing permissions and + ~ limitations under the License. + --> +<project basedir="." name="apache-cassandra-sonar-tasks" xmlns:if="ant:if" xmlns:unless="ant:unless"> + <property name="sonar-scanner-cli.version" value="5.0.1.3006-linux"/> + <property name="sonar.workdir" value="${build.dir}/sonar"/> + <property name="sonar.download.dir" value="${user.home}/.cassandra-cache/tools"/> + <property name="sonar-scanner.home" value="${sonar.download.dir}/sonar-scanner-${sonar-scanner-cli.version}"/> + <property name="sonar.projectKey" value="cassandra"/> + <property name="sonar.mainBranch" value="trunk"/> Review Comment: This would be nice to have automatically resolved based on what branch this file is in. I get that we will probably use this from now on only but once trunk is cassandra-5.1 and we are doing some patches for it, would not it be nice if we had a way how to run Sonar against that branch too without tweaking this property every time? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
