dcapwell commented on code in PR #57:
URL: https://github.com/apache/cassandra-accord/pull/57#discussion_r1302231320
##########
accord-core/src/test/java/accord/impl/basic/PendingQueue.java:
##########
@@ -23,9 +23,11 @@
public interface PendingQueue
{
void add(Pending item);
+ void addNoDelay(Pending item);
void add(Pending item, long delay, TimeUnit units);
boolean remove(Pending item);
Pending poll();
int size();
+ void checkFailures();
Review Comment:
we use `PendingQueue` and not `PropagatingPendingQueue`, so by changing the
signature we use I can move it there; this is leaking details of one impl.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]