Taher-Ghaleb opened a new pull request, #2624: URL: https://github.com/apache/cassandra/pull/2624
I am working on research that investigates test smell refactoring in which we identify alternative implementations of test cases, study how commonly used these refactorings are, and assess how acceptable they are in practice. This smell occurs when inappropriate assertions are used, while there exist better alternatives. For example, in [DiskBoundaryManagerTest.java](https://github.com/apache/cassandra/commit/bf2c5a44e86ef1b36c9ce756ad5fac1ec8e200e6#diff-2c0a8482948514ed8944fec2a26aa6af798d25351fd87c36c5f318181f30db71), I refactored `assertFalse(dbv1.equals(dbv2));` with `assertNotEquals(dbv1, dbv2);`. I would like to get your feedback on this particular test smell and its refactoring. Thanks in advance for your input. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
