5 commented on code in PR #66:
URL: https://github.com/apache/cassandra-sidecar/pull/66#discussion_r1303572549
##########
client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java:
##########
@@ -68,6 +70,32 @@ public SidecarClient(SidecarInstancesProvider
instancesProvider,
executor = requestExecutor;
}
+ /**
+ * Executes the Sidecar health request using the configured selection
policy and with no retries
+ *
+ * @return a completable future of the Sidecar health response
+ */
+ public CompletableFuture<HealthResponse> sidecarHealth()
+ {
+ return executor.executeRequestAsync(requestBuilder()
+ .sidecarHealthRequest()
+ .retryPolicy(new NoRetryPolicy())
Review Comment:
Replaced with `new BasicRetryPolicy(1)`, but it looks to me like the
behavior is exactly same…
Also, added unit tests for newly added methods.
##########
client/src/main/java/org/apache/cassandra/sidecar/client/SidecarClient.java:
##########
@@ -68,6 +70,32 @@ public SidecarClient(SidecarInstancesProvider
instancesProvider,
executor = requestExecutor;
}
+ /**
+ * Executes the Sidecar health request using the configured selection
policy and with no retries
+ *
+ * @return a completable future of the Sidecar health response
+ */
+ public CompletableFuture<HealthResponse> sidecarHealth()
+ {
+ return executor.executeRequestAsync(requestBuilder()
+ .sidecarHealthRequest()
+ .retryPolicy(new NoRetryPolicy())
Review Comment:
Replaced with `new BasicRetryPolicy(1)`, but it looks to me like the
behavior is exactly same…
Also, added unit tests for newly added methods.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
