belliottsmith commented on code in PR #57:
URL: https://github.com/apache/cassandra-accord/pull/57#discussion_r1307168273
##########
accord-core/src/main/java/accord/local/Node.java:
##########
@@ -172,7 +172,10 @@ public Node(Id id, MessageSink messageSink,
ConfigurationService configService,
// TODO (cleanup, testing): remove, only used by Maelstrom
public AsyncResult<Void> start()
{
- return onTopologyUpdateInternal(configService.currentTopology(),
false).metadata;
+ EpochReady ready =
onTopologyUpdateInternal(configService.currentTopology(), false);
+ ready.coordination.addCallback(() ->
this.topology.onEpochSyncComplete(id, topology.epoch()));
+ configService.acknowledgeEpoch(ready);
Review Comment:
That documentation appears to be wrong as it claims it's only used by
`Maelstrom`. So, let's document it as for testing only and perhaps call it
`unsafeStart` or `testStart` - otherwise this is cool by me.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
