arjunashok commented on code in PR #58:
URL: https://github.com/apache/cassandra-sidecar/pull/58#discussion_r1307958712
##########
common/src/main/java/org/apache/cassandra/sidecar/common/JmxClient.java:
##########
@@ -259,12 +259,16 @@ private Map<String, Object> buildJmxEnv()
}
@Override
- public synchronized void close() throws IOException
+ public void close() throws IOException
{
- JMXConnector connector = jmxConnector;
- if (connector != null)
+ JMXConnector connector;
+ synchronized (this)
{
+ connector = jmxConnector;
jmxConnector = null;
Review Comment:
Good catch. This would need to be reset to false to prevent false-positives
from `checkConnection`. Will add.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
