blerer commented on code in PR #2638:
URL: https://github.com/apache/cassandra/pull/2638#discussion_r1308434752
##########
build.xml:
##########
@@ -245,27 +245,22 @@
<string>--add-exports java.base/java.lang.ref=ALL-UNNAMED</string>
<string>--add-exports jdk.unsupported/sun.misc=ALL-UNNAMED</string>
<string>--add-exports
jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</string>
+ <string>--add-exports jdk.attach/sun.tools.attach=ALL-UNNAMED</string>
<string>--add-opens java.base/java.lang.module=ALL-UNNAMED</string>
- <string>--add-opens java.base/java.net=ALL-UNNAMED</string>
<string>--add-opens java.base/jdk.internal.loader=ALL-UNNAMED</string>
<string>--add-opens java.base/jdk.internal.ref=ALL-UNNAMED</string>
<string>--add-opens java.base/jdk.internal.reflect=ALL-UNNAMED</string>
<string>--add-opens java.base/jdk.internal.math=ALL-UNNAMED</string>
<string>--add-opens java.base/jdk.internal.module=ALL-UNNAMED</string>
<string>--add-opens
java.base/jdk.internal.util.jar=ALL-UNNAMED</string>
<string>--add-opens
jdk.management/com.sun.management.internal=ALL-UNNAMED</string>
- <string>--add-opens
jdk.management/com.sun.management.internal=ALL-UNNAMED</string>
-
<string>--add-opens java.base/sun.nio.ch=ALL-UNNAMED</string>
Review Comment:
If we have an `--add-opens` for `java.base/sun.nio.ch` do we need the
`--add-exports` ?
Same question for` java.base/java.lang`
##########
build.xml:
##########
@@ -245,27 +245,22 @@
<string>--add-exports java.base/java.lang.ref=ALL-UNNAMED</string>
<string>--add-exports jdk.unsupported/sun.misc=ALL-UNNAMED</string>
<string>--add-exports
jdk.compiler/com.sun.tools.javac.file=ALL-UNNAMED</string>
+ <string>--add-exports jdk.attach/sun.tools.attach=ALL-UNNAMED</string>
Review Comment:
Why do we need this one? It is apparently not needed by Chronicle Queue?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
