bschoening commented on code in PR #2653:
URL: https://github.com/apache/cassandra/pull/2653#discussion_r1312038127
##########
pylib/cqlshlib/cqlshmain.py:
##########
@@ -277,22 +276,10 @@ def __repr__(self):
return '<%s %s>' % (self.__class__.__name__, self.message())
-def maybe_ensure_text(val):
- return str(val) if val else val
-
-
class FormatError(DecodeError):
verb = 'format'
-def full_cql_version(ver):
- while ver.count('.') < 2:
- ver += '.0'
- ver_parts = ver.split('-', 1) + ['']
- vertuple = tuple(list(map(int, ver_parts[0].split('.'))) + [ver_parts[1]])
- return ver, vertuple
Review Comment:
The documentation at [Cassandra Query
Language](https://cassandra.apache.org/doc/latest/cassandra/cql/changes.html)
describes a valid version as only major/minor/patch.
> Versioning of the CQL language adheres to the [Semantic
Versioning](http://semver.org/) guidelines. Versions take the form X.Y.Z where
X, Y, and Z are integer values representing major, minor, and patch level
respectively. There is no correlation between Cassandra release versions and
the CQL language version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
