smiklosovic commented on code in PR #2649:
URL: https://github.com/apache/cassandra/pull/2649#discussion_r1317815845
##########
src/java/org/apache/cassandra/db/guardrails/Guardrails.java:
##########
@@ -189,10 +189,15 @@ public final class Guardrails implements GuardrailsMBean
*/
public static final EnableFlag bulkLoadEnabled =
new EnableFlag("bulk_load_enabled",
- null,
+ "Bulk loading of SSTables might potentially destabilize the
node.",
state ->
CONFIG_PROVIDER.getOrCreate(state).getBulkLoadEnabled(),
"Bulk loading of SSTables");
+ static
Review Comment:
I dont like this. Can't you just call that method as you instantiate
`bulkLoadEnabled`? Like this:
new EnableFlag("bulk_load_enabled",
null,
"Bulk loading of SSTables might potentially destabilize
the node.",
state ->
CONFIG_PROVIDER.getOrCreate(state).getBulkLoadEnabled(),
"Bulk loading of SSTables").throwOnNullClientState(true);
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
