maedhroz commented on code in PR #2660:
URL: https://github.com/apache/cassandra/pull/2660#discussion_r1317841050
##########
src/java/org/apache/cassandra/net/MessagingService.java:
##########
@@ -264,6 +239,36 @@ public static List<Version> supportedVersions()
return Collections.unmodifiableList(versions);
}
}
+ // Maintance Note:
+ // Try to keep Version enum in-sync for testing. By having the versions
in the enum tests can get access without forcing this class
+ // to load, which adds a lot of costs to each test
+ @Deprecated
+ public static final int VERSION_30 = 10;
Review Comment:
RE the comment above, can we not just make this...
```suggestion
public static final int VERSION_30 = Version.VERSION_30.value;
```
...and the same for the others?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
