ekaterinadimitrova2 commented on code in PR #2648:
URL: https://github.com/apache/cassandra/pull/2648#discussion_r1318693027
##########
src/java/org/apache/cassandra/auth/CIDRPermissionsCache.java:
##########
@@ -54,7 +54,7 @@ public CIDRPermissionsCache(Function<RoleResource,
CIDRPermissions> loadFunction
*/
public boolean invalidateCidrPermissions(String roleName)
{
- if (cache.getIfPresent(roleName) == null)
+ if (cache.getIfPresent(RoleResource.role(roleName)) == null)
Review Comment:
Thanks @yifan-c. There is actually this test class -
InvalidateCIDRPermissionsCacheTest but it doesn't seem to test properly. It
completes successfully with and without the change made. I think it doesn't
really assert that invalidation happens. What test did you write?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
