maedhroz commented on code in PR #2660:
URL: https://github.com/apache/cassandra/pull/2660#discussion_r1319147308
##########
test/unit/org/apache/cassandra/repair/ValidationTaskTest.java:
##########
@@ -52,10 +52,12 @@ public void shouldIgnoreTreesWhenDeactivated() throws
Exception
{
ValidationTask task = createTask();
assertTrue(task.isActive());
- task.abort();
+ task.abort(new RuntimeException());
assertFalse(task.isActive());
task.treesReceived(new MerkleTrees(null));
- assertNull(task.get());
+ // REVIEW: setting null would cause NPEs in sync task, so it was never
correct to set null
+ assertTrue(task.isDone());
+ assertFalse(task.isSuccess());
Review Comment:
So a `null` `TreeResponse` could arrive at, for instance,
`createStandardSyncTasks()` and be dereferenced?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
