dcapwell commented on code in PR #2660:
URL: https://github.com/apache/cassandra/pull/2660#discussion_r1320328813
##########
src/java/org/apache/cassandra/repair/AsymmetricRemoteSyncTask.java:
##########
@@ -39,14 +39,14 @@
*/
public class AsymmetricRemoteSyncTask extends SyncTask implements
CompletableRemoteSyncTask
{
- public AsymmetricRemoteSyncTask(RepairJobDesc desc, InetAddressAndPort to,
InetAddressAndPort from, List<Range<Token>> differences, PreviewKind
previewKind)
+ public AsymmetricRemoteSyncTask(SharedContext.RepairContext ctx,
RepairJobDesc desc, InetAddressAndPort to, InetAddressAndPort from,
List<Range<Token>> differences, PreviewKind previewKind)
{
- super(desc, to, from, differences, previewKind);
+ super(ctx, desc, to, from, differences, previewKind);
}
public void startSync()
{
- InetAddressAndPort local = FBUtilities.getBroadcastAddressAndPort();
+ InetAddressAndPort local = ctx.broadcastAddressAndPort();
Review Comment:
rather not change as its easier to port from
`FBUtilities.getBroadcastAddressAndPort` this way IMO. Changing the name could
be more confusing
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
