dcapwell commented on code in PR #2660:
URL: https://github.com/apache/cassandra/pull/2660#discussion_r1322180141
##########
src/java/org/apache/cassandra/service/ActiveRepairService.java:
##########
@@ -828,6 +868,13 @@ public void handleMessage(Message<? extends RepairMessage>
message)
if (session == null)
{
+ switch (message.verb())
+ {
+ case VALIDATION_RSP:
+ case SYNC_RSP:
+ ctx.messaging().send(message.emptyResponse(),
message.from());
Review Comment:
> Was there an issue here where senders of VALIDATION_RSP and SYNC_RSP would
sit around waiting for an ack that never came when the session couldn't be
found at the target node?
yes, tests found this bug.
> Also, do we need to send this response if the initiator is local?
No, but don't think we know that, so figure a ignored ack is fine
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
