jacek-lewandowski commented on code in PR #2689:
URL: https://github.com/apache/cassandra/pull/2689#discussion_r1327313271
##########
src/java/org/apache/cassandra/io/sstable/format/big/BigTableWriter.java:
##########
@@ -80,14 +80,23 @@ public class BigTableWriter extends
SortedTableWriter<BigFormatPartitionWriter>
public BigTableWriter(Builder builder, LifecycleNewTracker
lifecycleNewTracker, SSTable.Owner owner)
{
super(builder, lifecycleNewTracker, owner);
- checkNotNull(builder.getRowIndexEntrySerializer());
- checkNotNull(builder.getIndexWriter());
-
- this.rowIndexEntrySerializer = builder.getRowIndexEntrySerializer();
- this.indexWriter = builder.getIndexWriter();
- this.shouldMigrateKeyCache =
DatabaseDescriptor.shouldMigrateKeycacheOnCompaction()
- && lifecycleNewTracker instanceof
ILifecycleTransaction
- && !((ILifecycleTransaction)
lifecycleNewTracker).isOffline();
+
+ try
+ {
+ this.rowIndexEntrySerializer =
builder.getRowIndexEntrySerializer();
+ this.indexWriter = builder.getIndexWriter().get();
+
+ checkNotNull(builder.getRowIndexEntrySerializer());
+ checkNotNull(builder.getIndexWriter());
Review Comment:
right, my bad, moved checkNotNull but forgot to modify the arg
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
