dcapwell commented on code in PR #2660:
URL: https://github.com/apache/cassandra/pull/2660#discussion_r1327869275
##########
src/java/org/apache/cassandra/repair/RepairMessageVerbHandler.java:
##########
@@ -172,14 +194,23 @@ public void doVerb(final Message<RepairMessage> message)
ColumnFamilyStore store =
ColumnFamilyStore.getIfExists(desc.keyspace, desc.columnFamily);
if (store == null)
{
- logger.error("Table {}.{} was dropped during
validation phase of repair {}",
- desc.keyspace, desc.columnFamily,
desc.parentSessionId);
- vState.phase.fail(String.format("Table %s.%s was
dropped", desc.keyspace, desc.columnFamily));
-
MessagingService.instance().send(Message.out(VALIDATION_RSP, new
ValidationResponse(desc)), message.from());
+ String msg = String.format("Table %s.% was dropped
during validation phase of repair %s", desc.keyspace, desc.columnFamily,
desc.parentSessionId);
+ vState.phase.fail(msg);
+ logErrorAndSendFailureResponse(msg, message);
+ ctx.messaging().send(Message.out(VALIDATION_RSP,
new ValidationResponse(desc)), message.from());
return;
}
-
ActiveRepairService.instance.consistent.local.maybeSetRepairing(desc.parentSessionId);
+ try
+ {
+
ctx.repair().consistent.local.maybeSetRepairing(desc.parentSessionId);
+ }
+ catch (Throwable t)
+ {
+ JVMStabilityInspector.inspectThrowable(t);
+ logErrorAndSendFailureResponse(t.toString(),
message);
+ ctx.messaging().send(Message.out(VALIDATION_RSP,
new ValidationResponse(desc)), message.from());
Review Comment:
ok fixed this and added a new test to cover this for prepare / validation.
I don't know the best way to test sync as we don't really validate other than
"is the repair known"...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
