jonmeredith commented on code in PR #2693:
URL: https://github.com/apache/cassandra/pull/2693#discussion_r1333340099


##########
test/unit/org/apache/cassandra/security/SSLFactoryTest.java:
##########
@@ -296,9 +311,38 @@ public void 
testCacheKeyInequalityForCustomSslContextFactory() {
         .withSslContextFactory(new 
ParameterizedClass(DummySslContextFactoryImpl.class.getName(), parameters2))
         .withProtocol("TLSv1.1");
 
-        SSLFactory.CacheKey cacheKey2 = new 
SSLFactory.CacheKey(encryptionOptions2, ISslContextFactory.SocketType.SERVER
+        SSLFactory.CacheKey cacheKey2 = new 
SSLFactory.CacheKey(encryptionOptions2, ISslContextFactory.SocketType.SERVER, 
"test"
         );
 
         Assert.assertNotEquals(cacheKey1, cacheKey2);
     }
+
+    public static class TestFileBasedSSLContextFactory extends 
FileBasedSslContextFactory {

Review Comment:
   accidentally included in back port, used by other tests in 5.0/trunk



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to