maedhroz commented on code in PR #2715:
URL: https://github.com/apache/cassandra/pull/2715#discussion_r1333533902


##########
src/java/org/apache/cassandra/db/compaction/CompactionIterator.java:
##########
@@ -206,6 +206,17 @@ private UnfilteredPartitionIterators.MergeListener 
listener()
     {
         return new UnfilteredPartitionIterators.MergeListener()
         {
+            private boolean rowProcessingNeeded()
+            {
+                return type == OperationType.COMPACTION && 
controller.cfs.indexManager.hasIndexes();

Review Comment:
   This will trivially resolve to `true` right now unless we're using SAI, 
which doesn't care. (see `StorageAttachedIndex#indexerFor()`)



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to