smiklosovic commented on code in PR #2699:
URL: https://github.com/apache/cassandra/pull/2699#discussion_r1339690523
##########
test/unit/org/apache/cassandra/cql3/validation/operations/AlterTest.java:
##########
@@ -702,26 +702,15 @@ public void testAlterTableWithCompression() throws
Throwable
alterTable("ALTER TABLE %s WITH compression = { 'enabled' :
'false'};");
assertSchemaOption("compression", map("enabled", "false"));
- assertAlterTableThrowsException(ConfigurationException.class,
- "Missing sub-option 'class' for the
'compression' option.",
- "ALTER TABLE %s WITH compression =
{'chunk_length_in_kb' : 32};");
Review Comment:
I was thinking we do not need the whole statement but I need to get it back.
We need to read this in the context of what it does. It was testing what
happens if there is not `class` in `compression`. In that case it should fail
as it is missing. I probably removed that by accident when removing stuff for
sstable_compression option. `chunk_length_in_kb` is irrelevant here.
The solution here is to not remove this test.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
