adelapena commented on code in PR #2747:
URL: https://github.com/apache/cassandra/pull/2747#discussion_r1340390917
##########
test/unit/org/apache/cassandra/cql3/functions/masking/ColumnMaskQueryWithDefaultTest.java:
##########
@@ -39,7 +42,11 @@ public static Collection<Object[]> options()
options.add(new Object[]{ order, "DEFAULT", "text", "abc", "****"
});
options.add(new Object[]{ order, "DEFAULT", "int", 123, 0 });
options.add(new Object[]{ order, "mask_default()", "text", "abc",
"****" });
- options.add(new Object[]{ order, "mask_default()", "int", 123, 0,
});
+ options.add(new Object[]{ order, "mask_default()", "int", 123, 0
});
+ // TODO: the driver version that we use doesn't support vectors,
so we have to use raw values by now
+ options.add(new Object[]{ order, "mask_default()", "vector<int,
2>",
Review Comment:
These tests focus on how different queries interact with masking rather than
on what each particular function and data type combination does. It's useful to
test different functions just in case, but we cannot add too many combinations
here because each function/type variation multiplies the number of
parameterized cases, making the test slower. That's why we only test with a
single function and a few data types. At the moment the test takes 2-3 minutes
to run, and adding more cases might make it timeout on CI.
Instead, I have added a specific randomized/fuzz test on `AbstractTypeTest`
that would cover many data type combinations.
##########
test/unit/org/apache/cassandra/cql3/functions/masking/ColumnMaskQueryWithReplaceTest.java:
##########
@@ -43,6 +46,10 @@ public static Collection<Object[]> options()
options.add(new Object[]{ order, "mask_replace(0)", "int", 123, 0
});
options.add(new Object[]{ order, "mask_replace(0)", "bigint",
123L, 0L });
options.add(new Object[]{ order, "mask_replace(0)", "varint",
BigInteger.valueOf(123), BigInteger.ZERO });
+ // TODO: the driver version that we use doesn't support vectors,
so we have to use raw values by now
+ options.add(new Object[]{ order, "mask_replace([0, 0])",
"vector<int, 2>",
Review Comment:
Same as above.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
