bdeggleston commented on code in PR #66:
URL: https://github.com/apache/cassandra-accord/pull/66#discussion_r1343078960
##########
accord-core/src/main/java/accord/local/PreLoadContext.java:
##########
@@ -162,4 +162,6 @@ static PreLoadContext empty()
{
return contextFor(null, Collections.emptyList(), Keys.EMPTY);
}
+
+ PreLoadContext EMPTY_PRELOADCONTEXT = empty();
Review Comment:
unused
##########
accord-core/src/main/java/accord/messages/ReadData.java:
##########
@@ -68,10 +99,17 @@ protected ReadData(TxnId txnId, Participants<?> readScope,
long waitForEpoch)
this.waitForEpoch = waitForEpoch;
}
+ public ReadType kind()
Review Comment:
can this just be made abstract?
##########
accord-core/src/main/java/accord/local/SafeCommandStore.java:
##########
@@ -213,10 +212,15 @@ protected SafeCommand get(TxnId txnId)
* Visits keys first and then ranges, both in ascending order.
* Within each key or range visits TxnId in ascending order of queried
timestamp.
*/
- public abstract <T> T mapReduce(Seekables<?, ?> keys, Ranges slice,
+ public abstract <T> T mapReduceWithTerminate(Seekables<?, ?> keysOrRanges,
Ranges slice,
Review Comment:
same comment wrt removing `withTerminate` from the method name
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
