jacek-lewandowski commented on code in PR #2795:
URL: https://github.com/apache/cassandra/pull/2795#discussion_r1354808228
##########
src/java/org/apache/cassandra/cql3/statements/DescribeStatement.java:
##########
@@ -132,8 +132,13 @@ public final ResultMessage execute(QueryState state,
QueryOptions options, long
@Override
public ResultMessage executeLocally(QueryState state, QueryOptions options)
{
- Keyspaces keyspaces = Schema.instance.distributedAndLocalKeyspaces();
- UUID schemaVersion = Schema.instance.getVersion();
+ UUID schemaVersion;
+ Keyspaces keyspaces;
+ do
+ {
+ schemaVersion = Schema.instance.getVersionSync();
+ keyspaces = Schema.instance.distributedAndLocalKeyspaces();
Review Comment:
Not sure - is it a statement or question? I think we can skip this sync if
paging is not requested; if paging was requested and there happened what you
say, we would never be able to return results as paging would always fail due
to concurrent schema changes. On the other hand - I don't know under what
circumstances that could happen?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
