smiklosovic commented on code in PR #2793:
URL: https://github.com/apache/cassandra/pull/2793#discussion_r1356653028
##########
src/java/org/apache/cassandra/cql3/statements/DescribeStatement.java:
##########
@@ -132,8 +132,13 @@ public final ResultMessage execute(QueryState state,
QueryOptions options, long
@Override
public ResultMessage executeLocally(QueryState state, QueryOptions options)
{
- Keyspaces keyspaces = Schema.instance.distributedAndLocalKeyspaces();
- UUID schemaVersion = Schema.instance.getVersion();
+ UUID schemaVersion;
+ Keyspaces keyspaces;
+ do
+ {
+ schemaVersion = Schema.instance.getVersionSync();
+ keyspaces = Schema.instance.distributedAndLocalKeyspaces();
Review Comment:
@jacek-lewandowski this seems interesting at first sight ... feels
unnatural. Basically, we set `keyspaces` but they are not used in `while`. Is
that `distributedAndLocalKeyspaces` doing something which will make
`getVersionSync` behave differently? Just asking ...
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
