mike-tr-adamson commented on code in PR #2673:
URL: https://github.com/apache/cassandra/pull/2673#discussion_r1358203049
##########
src/java/org/apache/cassandra/db/marshal/ByteArrayAccessor.java:
##########
@@ -236,6 +236,19 @@ public float toFloat(byte[] value)
return ByteArrayUtil.getFloat(value, 0);
}
+ @Override
+ public float[] toFloatArray(byte[] value, int dimension)
Review Comment:
I agree. FWIW we are only using the `ByteBuffer` implementation atm and that
does use `FloatBuffer.get`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]