blerer commented on code in PR #2713:
URL: https://github.com/apache/cassandra/pull/2713#discussion_r1358307839
##########
src/java/org/apache/cassandra/metrics/TableMetrics.java:
##########
@@ -280,7 +280,7 @@ private static Pair<Long, Long>
totalNonSystemTablesSize(Predicate<SSTableReader
{
long total = 0;
long filtered = 0;
- for (String keyspace : Schema.instance.getNonSystemKeyspaces().names())
+ for (String keyspace : Schema.instance.distributedKeyspaces().names())
Review Comment:
It seems that we are lying for TableMetrics too :-(
##########
src/java/org/apache/cassandra/db/Keyspace.java:
##########
@@ -770,12 +770,12 @@ public static Stream<Keyspace> allExisting()
public static Iterable<Keyspace> nonSystem()
Review Comment:
This one seems to be use only in Keyspace.drain where we should use
`nonLocalStrategy()` so we should be able to remove it.
##########
src/java/org/apache/cassandra/schema/Schema.java:
##########
@@ -246,9 +253,10 @@ private Keyspace maybeRemoveKeyspaceInstance(String
keyspaceName, Consumer<Keysp
}
}
+ @Deprecated(since = "4.1", forRemoval = true)
Review Comment:
I think that you can simply remove it.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
