dcapwell commented on code in PR #2805:
URL: https://github.com/apache/cassandra/pull/2805#discussion_r1358766171
##########
src/java/org/apache/cassandra/repair/CommonRange.java:
##########
@@ -21,21 +21,30 @@
import java.util.ArrayList;
import java.util.Collection;
+import java.util.Collections;
import java.util.Objects;
import java.util.Set;
import com.google.common.base.Preconditions;
import com.google.common.collect.ImmutableSet;
+import org.apache.cassandra.cache.IMeasurableMemory;
+import org.apache.cassandra.dht.Murmur3Partitioner;
import org.apache.cassandra.dht.Range;
import org.apache.cassandra.dht.Token;
import org.apache.cassandra.locator.InetAddressAndPort;
+import org.apache.cassandra.utils.FBUtilities;
+import org.apache.cassandra.utils.ObjectSizes;
/**
* Groups ranges with identical endpoints/transient endpoints
*/
-public class CommonRange
+public class CommonRange implements IMeasurableMemory
{
+ // REVIEW: I've heard from some that these should be on a single line,
others prefer them split out into separate lines
Review Comment:
https://cassandra.apache.org/_/development/code_style.html#multiline-statements
> Where possible prefer keeping a logical action to a single line. Prefer
introducing additional variables, or well-named methods encapsulating actions,
to multi-line statements - unless this harms clarity (e.g. in an already short
method).
> Try to keep lines under 120 characters, but use good judgment. It is
better to exceed this limit, than to split a line that has no natural splitting
points, particularly when the remainder of the line is boilerplate or easily
inferred by the reader.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
