michaelsembwever commented on code in PR #2787:
URL: https://github.com/apache/cassandra/pull/2787#discussion_r1360704188
##########
.build/run-tests.sh:
##########
@@ -84,7 +87,9 @@ _build_all_dtest_jars() {
fi
if [ -d ${TMP_DIR}/cassandra-dtest-jars ] && [
"https://github.com/apache/cassandra.git"; == "$(git -C
${TMP_DIR}/cassandra-dtest-jars remote get-url origin)" ] ; then
- until git -C ${TMP_DIR}/cassandra-dtest-jars fetch --quiet origin ; do
echo "git pull failed… trying again… " ; done
+ if [ "x" == "x${OFFLINE}" ] ; then
+ until git -C ${TMP_DIR}/cassandra-dtest-jars fetch --quiet origin ; do
echo "git fetch failed… trying again… " ; done
Review Comment:
it can, but you get the echo statements so it's visible to the user. they
can ctl-c it.
this poormans approach is repeated in a number of places. improving it
(which is smart) should be done together. and maybe just rewriting bash
altogether into something non-shit
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
