Mmuzaf commented on code in PR #2817:
URL: https://github.com/apache/cassandra/pull/2817#discussion_r1363659125
##########
src/java/org/apache/cassandra/service/CassandraDaemon.java:
##########
@@ -713,13 +710,22 @@ public void startNativeTransport()
if (nativeTransportService == null)
throw new IllegalStateException("setup() must be called first for
CassandraDaemon");
+ // this iterates over a collection of servers and returns true if one
of them is started
+ boolean alreadyRunning = nativeTransportService.isRunning();
+
+ // this might in practice start all servers which are not started yet
nativeTransportService.start();
+
+ // interact with gossip only in case if no server was started before
to signal they are started now
+ if (!alreadyRunning)
+ StorageService.instance.setRpcReady(true);
}
public void stopNativeTransport()
{
if (nativeTransportService != null)
{
+ StorageService.instance.setRpcReady(false);
Review Comment:
Should we call `StorageService#shutdownClientServers` instead or at least
remove `setRpcReady(false)` there?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
