michaelsembwever commented on code in PR #97:
URL: https://github.com/apache/cassandra-builds/pull/97#discussion_r1363818836
##########
build-scripts/cassandra-artifacts.sh:
##########
@@ -21,7 +21,7 @@ command -v docker >/dev/null 2>&1 || { echo >&2 "docker needs
to be installed";
# This script is deprecated, having been migrated to be in-tree since 5.0
cassandra_version="$(grep 'property\s*name=\"base.version\"' build.xml |sed
-ne 's/.*value=\"\([^"]*\)\".*/\1/p')"
cassandra_regx_supported_versions="^(2.2|3.0|3.11|4.0|4.1)(.[0-9]+)?$"
-[[ $cassandra_version =~ $cassandra_regx_supported_versions ]] || { echo
"Cassandra ${cassandra_version} not supported. (This script is in-tree since
5.0)"; exit 1; }
+#[[ $cassandra_version =~ $cassandra_regx_supported_versions ]] || { echo
"Cassandra ${cassandra_version} not supported. (This script is in-tree since
5.0)"; exit 1; }
Review Comment:
this is not needed. we know it is working already.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
