yifan-c commented on code in PR #2824:
URL: https://github.com/apache/cassandra/pull/2824#discussion_r1365968564
##########
src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java:
##########
@@ -554,6 +555,18 @@ public Builder sorted()
return this;
}
+ /**
+ * Defines the maximum SSTable size when using the sorted writer.
+ * By default, i.e. not specified, there is no maximum size limit for
the produced SSTable
+ * @param size the maximum size of each individual SSTable allowed
+ * @return this builder
+ */
+ public Builder withMaxSSTableSizeInMiBForSorted(int size)
+ {
+ this.maxSSTableSizeInMiBForSorted = size;
Review Comment:
Good point. I would prefer to log a warning here and let the write process
to proceed, since producing a single sstable is a valid behavior, but might not
be expected. How about this message?
"Maximum SSTable size is specified for the sorted CQLSSTableWriter, but the
value is negative, which disables the size limiting effectively. Please supply
a positive value in order to enforce size limiting for the produced SSTables."
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
