yifan-c commented on code in PR #73:
URL: https://github.com/apache/cassandra-sidecar/pull/73#discussion_r1369151475
##########
adapters/base/src/main/java/org/apache/cassandra/sidecar/adapters/base/TokenRangeReplicaProvider.java:
##########
@@ -285,7 +285,9 @@ String of(String endpoint)
{
LOGGER.debug("Found gossipInfoEntry={}", gossipInfoEntry);
String hostStatus = gossipInfoEntry.status();
- if (hostStatus != null &&
hostStatus.startsWith("BOOT_REPLACE,"))
+ String hostStatusWithPort =
gossipInfoEntry.statusWithPort();
+ if ((hostStatus != null &&
hostStatus.startsWith("BOOT_REPLACE,")) ||
+ (hostStatusWithPort != null &&
hostStatusWithPort.startsWith("BOOT_REPLACE,")))
Review Comment:
nit: it might be worth to add a warning when `STATUS` field is missing when
cluster runs in 4.x, since it marks a potential gossip bug. It is not the
sidecar's responsibility to monitor it, so I am fine without it too. I would
defer to your decision.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
