dcapwell commented on code in PR #2832:
URL: https://github.com/apache/cassandra/pull/2832#discussion_r1373851356
##########
src/java/org/apache/cassandra/repair/messages/RepairMessage.java:
##########
@@ -56,8 +60,23 @@
public abstract class RepairMessage
{
private enum ErrorHandling { NONE, TIMEOUT, RETRY }
- private static final CassandraVersion SUPPORTS_RETRY = new
CassandraVersion("5.0.0-alpha2.SNAPSHOT");
+ @VisibleForTesting
+ static final CassandraVersion SUPPORTS_RETRY = new
CassandraVersion("5.0.0-alpha2.SNAPSHOT");
private static final Map<Verb, CassandraVersion> VERB_TIMEOUT_VERSIONS;
+ public static final Set<Verb> ALLOWS_RETRY;
+ private static final Set<Verb> SUPPORTS_RETRY_WITHOUT_VERSION_CHECK =
Collections.unmodifiableSet(EnumSet.of(Verb.CLEANUP_MSG));
+ public static final RequestCallback<Object> NOOP_CALLBACK = new
RequestCallback<>()
Review Comment:
in this case I rather not. There isn't a reason to use a no-op callback in
MessagingService as `null` is what you actually want (noop has higher cost than
null...), but since we are doing retries we need a way to tell you we are done,
so this should really only be used with retries, so feel its best to stay here
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
