reevik commented on code in PR #2847:
URL: https://github.com/apache/cassandra/pull/2847#discussion_r1374317957


##########
src/java/org/apache/cassandra/io/sstable/CQLSSTableWriter.java:
##########
@@ -492,30 +496,50 @@ public Builder using(String modificationStatement)
             return this;
         }
 
+        /**
+         * Defines the maximum SSTable size in mebibytes when using the sorted 
writer.
+         * By default, i.e. not specified, there is no maximum size limit for 
the produced SSTable
+         *
+         * @param size the maximum sizein mebibytes of each individual SSTable 
allowed
+         * @return this builder
+         */
+        public Builder withMaxSSTableSizeInMiB(int size)
+        {
+            if (size <= 0)
+            {
+                logger.warn("A non-positive value for maximum SSTable size is 
specified, " +

Review Comment:
   A non-positive **or "zero" value**
   
   as zero is neither positive nor negative. 



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to