Claudenw commented on code in PR #2842:
URL: https://github.com/apache/cassandra/pull/2842#discussion_r1376050380
##########
src/java/org/apache/cassandra/service/StartupChecks.java:
##########
@@ -357,14 +357,26 @@ public void execute(StartupChecksOptions options) throws
StartupException
}
};
- public static final StartupCheck initSigarLibrary = new StartupCheck()
+ public static final StartupCheck checkProcessEnvironment = new
StartupCheck()
{
@Override
public void execute(StartupChecksOptions options)
{
if (options.isDisabled(getStartupCheckType()))
return;
- new SystemInfo().warnIfRunningInDegradedMode();
+
+ Optional<String> degradations = new SystemInfo().isDegraded();
+
+ if (degradations.isPresent())
+ {
+ String message = "Cassandra server running in degraded mode. "
+ degradations.get();
+ if
(CassandraRelevantProperties.TEST_IGNORE_PROCESS_ENVIRONMENT_CHECK.getBoolean()
||
CassandraRelevantProperties.TEST_IGNORE_PROCESS_ENVIRONMENT_CHECK.getBoolean())
Review Comment:
I checked, and can find only one place in the tests where TEST_IGNORE_SIGAR
is set and no place where any of the expected text is searched for. I think it
was used to report the status even if there was no issue so that it would be in
the logs in case there was some data that could be used for debugging tests.
I think that we should remove the flag and any processing based on the flag.
If a need arises we can adjust the visibility of SystemInfo methods or add new
methods as necessary.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
