aratno commented on code in PR #2813:
URL: https://github.com/apache/cassandra/pull/2813#discussion_r1388669029
##########
test/distributed/org/apache/cassandra/distributed/test/IncRepairCoordinatorErrorTest.java:
##########
@@ -51,7 +51,7 @@ public void errorTest() throws Exception
cluster.get(3).runOnInstance(() -> {
ActiveRepairService.instance.failSession(result.toString(),
true);
});
- assertThat(cluster.get(1).logs().watchFor("Can't transition
endpoints .* to FAILED").getResult()).isNotEmpty();
+ assertThat(cluster.get(1).logs().watchFor("Removing completed
session .* with state FINALIZED").getResult()).isNotEmpty();
Review Comment:
Talked about this with Caleb - I actually prefer the logs check because it's
more explicit than "nothing found in map" - it confirms that the specific
action (removal from `ARS.consistent.coordinated`) was taken, rather than the
more generic "no data found".
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
