Maxwell-Guo commented on PR #2777: URL: https://github.com/apache/cassandra/pull/2777#issuecomment-1808328587
> @amitdpawar here is the commit with the changes I propose - [jacek-lewandowski@1c51c0d](https://github.com/jacek-lewandowski/cassandra/commit/1c51c0db1fce3979e89b8d22c64119f32258d2d5) > > Feel free to check it, I'll work on tests now (@Maxwell-Guo, any thoughts?) Thank @jacek-lewandowski , I just left some comments , I feel that most of your commits are great. There are only a few points where I may still be a little confused. For example, I prefer the hierarchical structure you mentioned, if this is not accept this time , I think commitlog_disk_access_mode may be better , As direct io for log read when commitlog doing replay may finally be supported in the future , and different configuration for different disk access mode seems a bit redundant. As they seems are two big kind of configuration but hierarchical structure seem is only one . -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
